Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1449 +/- ##
============================================
- Coverage 82.43% 82.38% -0.05%
Complexity 4549 4549
============================================
Files 393 393
Lines 13553 13597 +44
Branches 1684 1679 -5
============================================
+ Hits 11172 11202 +30
- Misses 1509 1526 +17
+ Partials 872 869 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3dc1b25 to
90b9d1f
Compare
ice1000
reviewed
Dec 24, 2025
jit-compiler/src/main/java/org/aya/compiler/CompiledModule.java
Outdated
Show resolved
Hide resolved
jit-compiler/src/main/java/org/aya/compiler/CompiledModule.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR slightly refactors CompiledModule and ResolveInfo, by serializing/deserializing the
ResolveInfo.thisModule.exportdirectly instead of serializing/deserializing the context-related commands (such as Command.Import).Q: Why don't serialize context-related commands?
A: Commands are imperative, thus the order is important, furthermore, some definitions act like a command, such as
inductive, which introduces a sub-module, and it is very stupid to store the order information...Although serializing
ModuleExportdirectly may increase the size of,ayac, especiallyprelude.aya.