test(usage): mock the keychain cache write path in buffer tests - #34
Merged
Merged
Conversation
Follow-up to the #22 review (PRRT_kwDOUqBlWc6mTGSl): only the read side (statSync) was mocked, so a future full-miss test would write a real marker into the developer's ~/.cache. Mock writeFileSync and mkdirSync like usage-token.test.ts does, and add the miss-branch test: a dump-keychain scan finding nothing must record the keychain-fallback-empty marker and still yield no token. Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to the #22 review thread (PRRT_kwDOUqBlWc6mTGSl, non-blocking note):
beforeEachinusage-token-buffer.test.tsnow also mocksfs.writeFileSyncandfs.mkdirSync(same pattern asusage-token.test.ts), so no test can touch the real~/.cache/ccstatuslinevia the keychain-cache write path.security dump-keychainscan that finds nothing records thekeychain-fallback-emptymarker (writeFileSync(<…keychain-fallback-empty>, '')) andgetUsageToken()returns null — the branch perf(usage): cache empty macOS keychain scans for 30s #22 introduced is now covered, and the mocks are proven by it.Verification
bun test src/utils/__tests__/usage-token-buffer.test.ts— 2 pass; full suite + lint green on the branch.🤖 Generated with Claude Code