Conversation
The themes commits left 21 ESLint errors that turn the required Lint & Type Check job red for every branch off main. Apply the auto-fixes (stylistic, import ordering) and fix the rest by hand: prefer-find in PowerlineThemeSelector.test, ??= in powerline.ts, and a narrowing guard in renderer-regular-theme.test instead of the banned non-null assertions. Co-Authored-By: Claude Code <noreply@anthropic.com>
Owner
Author
|
Closing as redundant: main moved to b35114c (#21), which already landed the same lint fixes — after rebasing this branch onto the new base the diff is empty and bun run lint passes on main (verified locally). The remaining open lint-gated PR (e.g. #22) should re-run checks green against the updated base. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore(lint): fix pre-existing ESLint debt on main
main (74ba67f) carries 21 ESLint errors from the themes work (#12/#13) that were
committed without a lint pass. This makes the required "Lint & Type Check" job
red for every branch off main — including PR #22, whose own diff is clean.
What changed
bun run lint:fixclosed 17/21 (stylistic: arrow-parens, indent,import-newlines, import-x/order + the prefer-find rewrite).
src/utils/powerline.ts—cachedFontStatus ??= checkPowerlineFonts()(prefer-nullish-coalescing; behavior identical).
src/tui/components/__tests__/PowerlineThemeSelector.test.ts—.filter(...)[0]→.find(...)(prefer-find).src/utils/__tests__/renderer-regular-theme.test.ts— replaced theexpect(...).toBeDefined()+!pair with an explicit narrowing guardthat throws with a message (the auto-fixer's
!is banned byno-non-null-assertionin this repo).No lint rules disabled, no dependencies added.
Verification
bun run lint— exit 0 (tsc + eslint, same command CI runs).bun test— full suite, single run (see PR checks).Notes
Unblocks the CI gate for all open PRs based on main, notably #22 (its branch
inherits the red base; the PR's own files produce zero lint errors).
🤖 Generated with Claude Code