Skip to content

chore(lint): fix pre-existing ESLint errors on main - #24

Closed
axisrow wants to merge 1 commit into
mainfrom
ao/ccstatusline-15/lint-main
Closed

axisrow wants to merge 1 commit into
mainfrom
ao/ccstatusline-15/lint-main

Conversation

@axisrow

@axisrow axisrow commented Sep 27, 2026

Copy link
Copy Markdown
Owner

chore(lint): fix pre-existing ESLint debt on main

main (74ba67f) carries 21 ESLint errors from the themes work (#12/#13) that were
committed without a lint pass. This makes the required "Lint & Type Check" job
red for every branch off main — including PR #22, whose own diff is clean.

What changed

  • bun run lint:fix closed 17/21 (stylistic: arrow-parens, indent,
    import-newlines, import-x/order + the prefer-find rewrite).
  • Manual fixes for the remaining 4:
    • src/utils/powerline.ts — cachedFontStatus ??= checkPowerlineFonts()
      (prefer-nullish-coalescing; behavior identical).
    • src/tui/components/__tests__/PowerlineThemeSelector.test.ts —
      .filter(...)[0] → .find(...) (prefer-find).
    • src/utils/__tests__/renderer-regular-theme.test.ts — replaced the
      expect(...).toBeDefined() + ! pair with an explicit narrowing guard
      that throws with a message (the auto-fixer's ! is banned by
      no-non-null-assertion in this repo).

No lint rules disabled, no dependencies added.

Verification

  • bun run lint — exit 0 (tsc + eslint, same command CI runs).
  • bun test — full suite, single run (see PR checks).
  • Diff touches only the 7 files named by the failing lint job.

Notes

Unblocks the CI gate for all open PRs based on main, notably #22 (its branch
inherits the red base; the PR's own files produce zero lint errors).

🤖 Generated with Claude Code

The themes commits left 21 ESLint errors that turn the required
Lint & Type Check job red for every branch off main. Apply the
auto-fixes (stylistic, import ordering) and fix the rest by hand:
prefer-find in PowerlineThemeSelector.test, ??= in powerline.ts,
and a narrowing guard in renderer-regular-theme.test instead of
the banned non-null assertions.

Co-Authored-By: Claude Code <noreply@anthropic.com>
@axisrow

axisrow commented Sep 27, 2026

Copy link
Copy Markdown
Owner Author

Closing as redundant: main moved to b35114c (#21), which already landed the same lint fixes — after rebasing this branch onto the new base the diff is empty and bun run lint passes on main (verified locally). The remaining open lint-gated PR (e.g. #22) should re-run checks green against the updated base.

@axisrow axisrow closed this Sep 27, 2026
@axisrow
axisrow deleted the ao/ccstatusline-15/lint-main branch September 27, 2026 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant