Repository navigation
feat(providers): retry requests the llm-d router rejected (SHD-1094) - #38
Merged
Merged
Conversation
Signed-off-by: janosmurai <janos.murai@axem.dev>
11 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Related issue
Closes SHD-1094 (router retry).
Description
With llm-d v1.0, the router (EPP) can answer a request itself, for example with 503 while no model server pod is ready. It then sets
x-llm-d-request-dropped-reason. A reason starting withrejected-means no model server saw the request, so the platform provider now retries it: up to 3 attempts, with a backoff starting at 500 ms. This applies to chat, completion and embedding requests.evictedrequests already used GPU time and are not retried. Any other error is returned as before.Validation
cargo fmt --checkcargo clippy --all-targets --all-features -- -D warningscargo build --verbose --all-featurescargo test --verbose --all-featuresAdditional validation details:
Deployment and compatibility
None. Responses without the header behave as before, so the change is safe with the pre-v1.0 serving stack.
Documentation
None needed: internal provider behavior.
Checklist
Signed-off-bytrailer (git commit -s).AI assistance: