Skip to content

fix(deploy-on-aws): check file extension before defusedxml dependency #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sagargupta16 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(deploy-on-aws): check file extension before defusedxml dependency #132

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7c39ea
fix(deploy-on-aws): check file extension before defusedxml dependency
Sagargupta16 Apr 15, 2026
6422b0a
chore: trigger CI re-run for contributor statement check
Sagargupta16 Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions plugins/deploy-on-aws/scripts/validate-drawio.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,6 @@ set -euo pipefail

SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"

# Ensure defusedxml is available (required for safe XML parsing)
# See scripts/requirements.txt or plugin README for installation instructions
python3 -c "import defusedxml" 2>/dev/null || {
echo '{"systemMessage": "Missing required dependency: defusedxml. Install it with: pip3 install defusedxml>=0.7.1"}'
exit 0
}

# Read stdin (hook input JSON)
INPUT=$(cat)

Expand All @@ -29,7 +22,7 @@ except (json.JSONDecodeError, KeyError, TypeError, ValueError):
print('')
" 2>/dev/null || echo "")

# Only validate .drawio or .drawio.xml files
# Only validate .drawio or .drawio.xml files -- exit early for all other files
if [[ -z "$FILE_PATH" ]]; then
exit 0
fi
Expand All @@ -42,6 +35,13 @@ if [[ ! -f "$FILE_PATH" ]]; then
exit 0
fi

# Ensure defusedxml is available (required for safe XML parsing)
# See scripts/requirements.txt or plugin README for installation instructions
python3 -c "import defusedxml" 2>/dev/null || {
echo '{"systemMessage": "Missing required dependency: defusedxml. Install it with: pip3 install defusedxml>=0.7.1"}'
exit 0
}

# Step 0: Run post-processing fixers BEFORE validation
# This fixes badge overlaps, external actor placement, and legend sizing
# timeout prevents runaway processes from blocking the hook indefinitely
Expand Down