feat(s2n-quic-bench): Add stress test for s2n-quic servers#3010
Open
Mark-Simulacrum wants to merge 7 commits intoaws:mainfrom
Open
feat(s2n-quic-bench): Add stress test for s2n-quic servers#3010Mark-Simulacrum wants to merge 7 commits intoaws:mainfrom
Mark-Simulacrum wants to merge 7 commits intoaws:mainfrom
Conversation
c30543f to
36cc6a7
Compare
aa454b6 to
f705f2d
Compare
maddeleine
reviewed
Mar 24, 2026
| type Error = Box<dyn std::error::Error + Send + Sync>; | ||
|
|
||
| pub fn build_client_mtls_provider(ca_cert: &str) -> Result<tls::default::Client, Error> { | ||
| let tls = tls::default::Client::builder() |
Contributor
There was a problem hiding this comment.
Note: This doesn't affect the results of the benchmark, but this code creates clients that are initialized to load system certs into their trust store. This is expensive, especially since we're creating a lot of clients here. Again, doesn't affect latency statistics but this does show up in perf logs so I thought I'd make a note.
This is intended to help with optimizing the behavior of high-concurrency handshaking with a single s2n-quic server.
25eb6e8 to
8cb4109
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
n/a
Description of changes:
This is intended to help with optimizing the behavior of high-concurrency handshaking with a single s2n-quic server.
Call-outs:
This change is just adding a benchmark, but it also contains some tweaks to s2n-quic-dc's current client code to make it easier to write that benchmark. I suspect we'll want to move the benchmark away from using s2n-quic-dc if possible since that's just expanding the scope and likely the problems it's trying to bring up could be reproduced without it. But leaving that for future PRs.
Testing:
Ran the benchmark locally with varying concurrency levels and saw roughly expected results.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.