fix: dead loop inside SocaCliContext.aws() in case of SSO credentials#72
Open
staskh wants to merge 1 commit intoaws:mainlinefrom
Open
fix: dead loop inside SocaCliContext.aws() in case of SSO credentials#72staskh wants to merge 1 commit intoaws:mainlinefrom
staskh wants to merge 1 commit intoaws:mainlinefrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix dead loop inside SocaCliContext.aws()
When AWS credentials are received via SSO, the original code is entering an endless loop, resulting in a RecursionError exception.
To replicate error:
How was this PR tested?
Please describe any testing performed.
Manual test:
Checklist
License
Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.te this contribution, under the terms of your choice.