ModifiedFilestracker-component#440
Draft
sacrodge wants to merge 64 commits intoaws:feature/upgrade-modified-files-uxfrom
Draft
ModifiedFilestracker-component#440sacrodge wants to merge 64 commits intoaws:feature/upgrade-modified-files-uxfrom
sacrodge wants to merge 64 commits intoaws:feature/upgrade-modified-files-uxfrom
Conversation
… etc. consistent with initial commit for LS
… etc. consistent with initial commit for LS
…le in diff mode. Logging enabled, disable later. Undo buttons still not working
…le in diff mode. Logging enabled, disable later. Undo buttons still not working
…le in diff mode. Logging enabled, disable later. Undo buttons still not working
…le in diff mode. Logging enabled, disable later. Undo buttons still not working
…le in diff mode. Logging enabled, disable later. Undo buttons still not working
- Currently gets file details just like chatItemCard - Files are listed but other functionalities are lacking
- Currently gets file details just like chatItemCard - Files are listed but other functionalities are lacking
- refactored the code to use array for storing the modified files - separate elements were causing maintainability issues - Now the undo button per file is getting displayed and works fine
- This version now renders undo as well as undoAll buttons - These buttons are fully functional - Styling is not perfect and undoAll button renders below files
- This version now renders undo as well as undoAll buttons - These buttons are fully functional - Styling is not perfect and undoAll button renders below files
- styling looks good - undo functionality fully functional - undoAll is intermittently working - Need to flush older files before rendering new ones
- styling looks good - undo functionality fully functional - undoAll is intermittently working - Need to flush older files before rendering new ones
- Fully functional demo completed - just need to check how to flush the old files - decide if it needs to be done from mynah or language-servers - and add undoAll button to the title element
- made the compnent more data driven to have LS do the title change - The working... shows correctly but later goes back to no-files-modifed instead of showing count - The component is hidden only for the intial chat though on the new chat it shows by default
- made the compnent more data driven to have LS do the title change - The working... shows correctly but later goes back to no-files-modifed instead of showing count - The component is hidden only for the intial chat though on the new chat it shows by default
- Styled component to be attached to chat prompt window - Set the default visibility to hidden, which is working - (x) files modified! status doesn't reflect yet
- component title now changes from LS - Need more functinalities offloaded from mynah to SL - For now working on session reset
- component title now changes from LS - Need more functinalities offloaded from mynah to SL - For now working on session reset; removed some redundant code
- Added tests for the new component
- Have completely shifted logic to LS and only kept rendering part in mynah - Was only able to render the modified files not undo buttons - Using existing fileList and creating a new array like datastructure
- Handles file-click, undo and undo-all functionality - session management is also working needs a recheck though - see if files can be sent one by one instead of all at once
- In the previous working model undoall functionality was breaking for all - Checked undo, undoall file-click, all functionalities work - Need to remove logging and unnecessary codes - Remove old tests as they are not useful - remove blockers mentioned from quip today and do pr
- files and undo per file rendering and working correctly - undoall logic not correct and not working
- files and undo per file rendering and working correctly - undoall logic not correct and not working
- UndoAll button only undoes the last file modification - undo buttons work - File click works
- Files are rendering correctly with undo and undoall buttons - Buttons are all clickable and working - However, upon multiple chats, sometimes nothing is rendering - need further testing
- Files are rendering correctly with undo and undoall buttons - Buttons are all clickable and working - However, upon multiple chats, sometimes nothing is rendering - need further testing
- Files, buttons rendering and fully functional - session manager is clearing older files for every new chat - blockers : undoall is rendered too early - component should hide initially and show working when prompted - If no files were modified as a result of the chat it should hide again
- added quick-action demo back to the UI. - Still utilizes legacy mode
- removed unnecessary logging and made a little more type safe
sacrodge
changed the base branch from
main
to
feature/upgrade-modified-files-ux
Contributor
|
Test cases are failing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Modified files are scattered across multiple chatItem cards and can be lost for users if too many files are modified and has verbose explanation. Needed access to files in one palce
Solution
Created a new separate component which renders just modified files along with undo and undoall buttons
Additional comments
This is just draft for commenting. Working on removing (as any) from all files to make the component type safe.
Tests
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.