Skip to content

fix(payments): use RUNTIME_ROLE_ARN for CP integ tests#461

Merged
aidandaly24 merged 2 commits intomainfrom
fix/payments-integ-test-role-arn
May 7, 2026
Merged

fix(payments): use RUNTIME_ROLE_ARN for CP integ tests#461
aidandaly24 merged 2 commits intomainfrom
fix/payments-integ-test-role-arn

Conversation

@aidandaly24
Copy link
Copy Markdown
Contributor

Summary

  • Replace hardcoded dummy role ARN (123456789012) with RUNTIME_ROLE_ARN env var
  • Add pytest.skip() when env var not set (matches runtime/gateway/memory test pattern)
  • Fix duplicate @classmethod decorator and duplicate role_arn assignment

Test plan

  • Tests skip cleanly when RUNTIME_ROLE_ARN not set (10 skipped, 0 failed)
  • Syntax valid, collection works
  • Tests pass when RUNTIME_ROLE_ARN is set to a valid payment-capable role

@aidandaly24 aidandaly24 requested a review from a team May 7, 2026 21:41
@aidandaly24 aidandaly24 force-pushed the fix/payments-integ-test-role-arn branch from 1ffe714 to 821590b Compare May 7, 2026 21:46
Replace hardcoded dummy role ARN with env var lookup matching the
pattern used by other integ test groups (runtime, gateway, etc.).
Tests skip gracefully when RUNTIME_ROLE_ARN is not set.
@aidandaly24 aidandaly24 force-pushed the fix/payments-integ-test-role-arn branch from 821590b to 64b0d65 Compare May 7, 2026 21:49
@aidandaly24 aidandaly24 merged commit 65df922 into main May 7, 2026
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants