feat: add DatasetClient for Dataset Management API#451
Closed
Conversation
Implements DatasetClient mirroring GatewayClient pattern with single bedrock-agentcore-control boto3 client, __getattr__ dispatch for create/get/list/update/delete_dataset, and wait helpers.
- Export DatasetClient from top-level bedrock_agentcore package
- Unwrap response["dataset"] in polling lambdas for create/update_and_wait
- Add clientToken (uuid4) idempotency to create_dataset_and_wait
- Guard delete_dataset_and_wait with response.get("datasetId") + ValueError
- Add get_paginator and get_waiter to _ALLOWED_CP_METHODS
- Update tests to 100% coverage (24 tests) covering all new behaviours
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Contributor
✅ No Breaking Changes DetectedNo public API breaking changes found in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DatasetClientinsrc/bedrock_agentcore/dataset/client.pyfollowing theGatewayClientpatternbedrock-agentcore-controlboto3 client with_ALLOWED_CP_METHODSallowlist and__getattr__dispatchcreate_dataset_and_wait,update_dataset_and_wait,delete_dataset_and_waitclientTokenidempotency,get_paginator/get_waitersupport, response unwrapping fixedTest plan
bedrock_agentcore/dataset/🤖 Generated with Claude Code