Potential fix for code scanning alert no. 3: Workflow does not contain permissions#189
Closed
simonmarty wants to merge 2 commits intomainfrom
Closed
Potential fix for code scanning alert no. 3: Workflow does not contain permissions#189simonmarty wants to merge 2 commits intomainfrom
simonmarty wants to merge 2 commits intomainfrom
Conversation
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Simon Marty <simon.marty@protonmail.com>
Signed-off-by: Simon Marty <martysi@amazon.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #189 +/- ##
=======================================
Coverage 92.14% 92.14%
=======================================
Files 14 14
Lines 2405 2405
Branches 2405 2405
=======================================
Hits 2216 2216
Misses 143 143
Partials 46 46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/aws/aws-secretsmanager-agent/security/code-scanning/3
In general, this issue is fixed by explicitly declaring a
permissionsblock in the workflow (either at the top level or per job) and setting it to the minimal scopes the workflow actually needs. For this Docker build workflow, the steps only need to read repository contents (for checkout); there is no need to write to the repo or interact with issues, PRs, or other resources, socontents: readis sufficient.The best fix here is to add a job‑level
permissionsblock underjobs.build(indented to align withstrategy:andruns-on:) and setcontents: read. This constrains theGITHUB_TOKENused by this job without affecting other workflows. Concretely, edit.github/workflows/docker.ymland insert:between the
build:line and thestrategy:line (or betweenruns-on:andsteps:; both are valid, but we’ll place it immediately afterbuild:for clarity). No additional methods, imports, or definitions are required because this is purely a YAML configuration change for GitHub Actions.Suggested fixes powered by Copilot Autofix. Review carefully before merging.