Skip to content

Remove actions-rs/toolchain, cache dependencies#187

Merged
simonmarty merged 5 commits intoaws:mainfrom
simonmarty:update-ci
Apr 3, 2026
Merged

Remove actions-rs/toolchain, cache dependencies#187
simonmarty merged 5 commits intoaws:mainfrom
simonmarty:update-ci

Conversation

@simonmarty
Copy link
Copy Markdown
Contributor

@simonmarty simonmarty commented Apr 2, 2026

Description

https://github.com/actions/cache/blob/main/examples.md#rust---cargo

Why is this change being made?

  1. actions-rs/toolchain is no longer maintained and still on Node 20.
  2. The cargo-deny step takes a long time because it has to fetch the dependencies, even if Cargo.lock has not changed since the last execution.

What is changing?

  1. Replace actions-rs/toolchain with rustup commands. rustup is provided on the GitHub hosted runners.
  2. Cache rust dependencies and build artifacts on a hash of the Cargo.lock file.

Related Links

  • Issue #, if available:

Testing

How was this tested?

  1. Tested on fork, reduces consecutive build times from 23 minutes to 3 minutes on Windows (the slowest build target).

When testing locally, provide testing artifact(s):

  1. First run: https://github.com/simonmarty/aws-secretsmanager-agent/actions/runs/23924128450
  2. Second run: https://github.com/simonmarty/aws-secretsmanager-agent/actions/runs/23926285140

Reviewee Checklist

Update the checklist after submitting the PR

  • I have reviewed, tested and understand all changes
    If not, why:
  • I have filled out the Description and Testing sections above
    If not, why:
  • Build and Unit tests are passing
    If not, why:
  • Unit test coverage check is passing
    If not, why:
  • Integration tests pass locally
    If not, why:
  • I have updated integration tests (if needed)
    If not, why:
  • I have ensured no sensitive information is leaking (i.e., no logging of sensitive fields, or otherwise)
    If not, why:
  • I have added explanatory comments for complex logic, new classes/methods and new tests
    If not, why:
  • I have updated README/documentation (if needed)
    If not, why:
  • I have clearly called out breaking changes (if any)
    If not, why:

Reviewer Checklist

All reviewers please ensure the following are true before reviewing:

  • Reviewee checklist has been accurately filled out
  • Code changes align with stated purpose in description
  • Test coverage adequately validates the changes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@simonmarty simonmarty requested a review from a team as a code owner April 2, 2026 23:09
@simonmarty simonmarty requested a review from reyhankoyun April 2, 2026 23:18
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.14%. Comparing base (2053c88) to head (8a9e036).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #187   +/-   ##
=======================================
  Coverage   92.14%   92.14%           
=======================================
  Files          14       14           
  Lines        2405     2405           
  Branches     2405     2405           
=======================================
  Hits         2216     2216           
  Misses        143      143           
  Partials       46       46           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@simonmarty simonmarty added the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Apr 2, 2026
@github-actions github-actions bot removed the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Apr 2, 2026
@simonmarty simonmarty enabled auto-merge (squash) April 3, 2026 21:02
harsheejshah
harsheejshah previously approved these changes Apr 3, 2026
Copy link
Copy Markdown

@madsid madsid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@simonmarty simonmarty removed the request for review from reyhankoyun April 3, 2026 21:31
@simonmarty simonmarty added the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Apr 3, 2026
@github-actions github-actions bot removed the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Apr 3, 2026
@simonmarty simonmarty merged commit 7932392 into aws:main Apr 3, 2026
12 checks passed
@simonmarty simonmarty deleted the update-ci branch April 5, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants