Skip to content

Drop the fips feature#179

Merged
simonmarty merged 6 commits intoaws:mainfrom
simonmarty:remove-fips
Apr 7, 2026
Merged

Drop the fips feature#179
simonmarty merged 6 commits intoaws:mainfrom
simonmarty:remove-fips

Conversation

@simonmarty
Copy link
Copy Markdown
Contributor

Description

Why is this change being made?

  1. rustls dropped the fips feature in rustls/rustls@13da394

What is changing?

  1. Remove the feature and associated documentation. This is technically a breaking change.

Related Links

  • Issue #, if available:

Testing

How was this tested?

When testing locally, provide testing artifact(s):


Reviewee Checklist

Update the checklist after submitting the PR

  • I have reviewed, tested and understand all changes
    If not, why:
  • I have filled out the Description and Testing sections above
    If not, why:
  • Build and Unit tests are passing
    If not, why:
  • Unit test coverage check is passing
    If not, why:
  • Integration tests pass locally
    If not, why: Running them in GH actions
  • I have updated integration tests (if needed)
    If not, why:
  • I have ensured no sensitive information is leaking (i.e., no logging of sensitive fields, or otherwise)
    If not, why:
  • I have added explanatory comments for complex logic, new classes/methods and new tests
    If not, why:
  • I have updated README/documentation (if needed)
    If not, why:
  • I have clearly called out breaking changes (if any)
    If not, why:

Reviewer Checklist

All reviewers please ensure the following are true before reviewing:

  • Reviewee checklist has been accurately filled out
  • Code changes align with stated purpose in description
  • Test coverage adequately validates the changes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@simonmarty simonmarty requested a review from a team as a code owner March 27, 2026 18:35
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.14%. Comparing base (7932392) to head (5eceea6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #179   +/-   ##
=======================================
  Coverage   92.14%   92.14%           
=======================================
  Files          14       14           
  Lines        2405     2405           
  Branches     2405     2405           
=======================================
  Hits         2216     2216           
  Misses        143      143           
  Partials       46       46           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@simonmarty simonmarty added the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Mar 27, 2026
@github-actions github-actions bot removed the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Mar 27, 2026
@simonmarty simonmarty requested review from a team, ThirdEyeSqueegee and i-am-SR and removed request for a team March 27, 2026 19:57
@simonmarty simonmarty added the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Apr 2, 2026
@github-actions github-actions bot removed the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Apr 2, 2026
i-am-SR
i-am-SR previously approved these changes Apr 2, 2026
@simonmarty
Copy link
Copy Markdown
Contributor Author

Let's do the config file option in a future CR, it's technically a behavior change. Prioritizing fixing the cargo publish failures.

@simonmarty simonmarty added the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Apr 2, 2026
@github-actions github-actions bot removed the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Apr 2, 2026
@simonmarty simonmarty removed the request for review from ThirdEyeSqueegee April 2, 2026 22:12
@simonmarty simonmarty enabled auto-merge (squash) April 2, 2026 22:16
i-am-SR
i-am-SR previously approved these changes Apr 2, 2026
@simonmarty simonmarty requested a review from lohdipak April 2, 2026 22:17
@harsheejshah
Copy link
Copy Markdown

- name: Install ninja-build tool for aws-lc-fips-sys on Windows
we still have some stale commands

@simonmarty simonmarty added safe-to-test Maintainer approval to run integration tests for external contributor PRs. labels Apr 6, 2026
@github-actions github-actions bot removed the safe-to-test Maintainer approval to run integration tests for external contributor PRs. label Apr 6, 2026
@simonmarty simonmarty merged commit 01429bb into aws:main Apr 7, 2026
13 checks passed
@simonmarty simonmarty deleted the remove-fips branch April 7, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants