Skip to content
This repository was archived by the owner on Aug 7, 2026. It is now read-only.

fix(assetlibrary): add retry mechanism for connection error - #178

Open
yuma124 wants to merge 3 commits into
aws:mainfrom
yuma124:featrue_assetlibrary_retry
Open

fix(assetlibrary): add retry mechanism for connection error#178
yuma124 wants to merge 3 commits into
aws:mainfrom
yuma124:featrue_assetlibrary_retry

Conversation

@yuma124

@yuma124 yuma124 commented Oct 30, 2023

Copy link
Copy Markdown
Contributor

Description

Since #168, we have occasionally encountered database connection errors. These errors are related to database connectivity, and in my opinion they should be retried in the AssetLibrary. In this Pull Request, I've added retry mechanism for connection errors.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (existing code being refactored)
  • This change includes a documentation update

Submission Checklist

  • CI dry-run passing
  • Integration tests passing locally
  • Change logs generated
Additional Notes:

@canavandl

Copy link
Copy Markdown
Contributor

Thanks for the PR @yuma124 ! I'll aim to review it by end-of-week

@aaronatbissell

aaronatbissell commented Jan 26, 2024

Copy link
Copy Markdown
Contributor

I feel like a more proper fix here would be to open the DB connection outside of the lambda handler (from here):

A common best practice is to open the database connection outside the Lambda handler function so that it can be reused with each handler call.

@ts-amz

ts-amz commented Jan 26, 2024

Copy link
Copy Markdown
Contributor

I feel like a more proper fix here would be to open the DB connection outside of the lambda handler (from here):

A common best practice is to open the database connection outside the Lambda handler function so that it can be reused with each handler call.

+1 to this.

@yuma124

yuma124 commented Jan 29, 2024

Copy link
Copy Markdown
Contributor Author

@aaronatbissell @ts-amz
Thank you for your suggestion. I understand the importance of reusing the DB connection with each handler call. I have structured the code in a way that allows the DB connection to be reused within the Lambda's execution context.

Is it necessary to open the DB connection outside of the Lambda handler? If we refer to the Neptune sample code here, we can see that they also open the DB connection in the lambda handler and reuse with each handler call.

If there are any specific concerns or aspects that you think I might have overlooked, please let me know.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants