This repository was archived by the owner on May 31, 2024. It is now read-only.
feat: Added option to pass custom WES Adapter environment variables#418
Closed
kankou-aliaksei wants to merge 1 commit intoaws:mainfrom
Closed
feat: Added option to pass custom WES Adapter environment variables#418kankou-aliaksei wants to merge 1 commit intoaws:mainfrom
kankou-aliaksei wants to merge 1 commit intoaws:mainfrom
Conversation
Contributor
markjschreiber
left a comment
There was a problem hiding this comment.
I like the idea but I wonder why these variables are being set at the account activate level? If you set wes env vars at the level of account activate then these would apply to all WES adapters used even though each engine has it's own WES adapter and potentially each WES adapter could behave very differently. I wonder if it would be better to move the CLI flag to the agc context deploy command? That would let you deploy each context with the ENV flags appropriate to that WES adapter.
Contributor
|
related to #396 |
Contributor
Author
|
See #420 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
[//]: # This adds option to pass custom environment variables into WES Adapter
[//]: # This adds option to pass custom environment variables into Workflow Job
Description of how you validated changes
[//]: # agc account activate --customWesEnvVars "CUSTOM_WORKFLOW_JOB_ENVIRONMENTS=[{ \"name\": \"MINIWDL__AWS__DESCRIBE_PERIOD\", \"value\": 10 }, { \"name\": \"MINIWDL__AWS__SUBMIT_PERIOD\", \"value\": 10 }]"
[//]: # After agc account activate the SSM parameter /agc/_common/customWesEnvVars must be set
[//]: # agc configure email you@youremail.com
[//]: # After agc context deploy --context miniContext a WES Adapter Lambda must have CUSTOM_WORKFLOW_JOB_ENVIRONMENTS env var
[//]: # After agc workflow run hello --context miniContext go to Batch Workflow Job Logs and find MINIWDL__AWS__DESCRIBE_PERIOD and MINIWDL__AWS__SUBMIT_PERIOD under === ENVIRONMENT === section
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license