test: phase 1 — add missing integration tests (validate, runtime-endpoint, import)#1118
Closed
test: phase 1 — add missing integration tests (validate, runtime-endpoint, import)#1118
Conversation
Contributor
Coverage Report
|
|
Reviewed the changes end-to-end. Traced each assertion back to the production code paths:
Tests-only change, no production behavior impact. LGTM to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What This PR Does
Closes the Phase 1 integration test gaps identified in the missing test coverage analysis.
All tests in this PR run locally — no AWS credentials required.
📋 Full missing test coverage analysis: https://gist.github.com/jariy17/a03bfb46ac9b32195aa3382919e3a913
Tests Added
integ-tests/validate.test.ts(extended — 4 new cases)aws-targets.jsondeployed-state.jsonaws-targets.jsonaws-targets.jsoninteg-tests/add-remove-runtime-endpoint.test.ts(new — 4 cases)agentcore.jsonagentcore.jsoninteg-tests/import.test.ts(new — 2 cases)Test Results
Phases
This PR is Phase 1 of a multi-phase plan to close missing test coverage across the CLI.
validate,runtime-endpoint,importerror paths — local only, no AWSpackage,update,fetchlocal state path — local only, no AWSdeployed-state.jsonvalidation after deploy,logsfilteringfetchtoken generation,statusall resource types,traces getrun batch-evaluation,run recommendation,run evalARN modeimportsubcommands, multi-target deploymentsKnown Gaps Not In This PR
tag—action.tsexists but nocommand.tsand not registered in the CLI;agentcore tagis not a real command yetruntime-endpointdependency check — removing an endpoint referenced by an online-eval config is not validated in production code; needs a source change before it can be testedimportvalid-YAML path — the happy path where valid YAML mutatesagentcore.jsonwas held back pending confirmation that Phase 1 is fully local with no physical resource IDsNotes
deployed-state.jsonlives atagentcore/.cli/deployed-state.jsonperPathResolver.getStatePath;formatErrorlabels it.cli/state.jsonin error output — tests assert on that label verbatimagentcore import --source ...does not expose--json; import tests assert on combined stdout/stderr strings