test: add integ tests for batch evaluation and evaluator lifecycle#1109
Open
test: add integ tests for batch evaluation and evaluator lifecycle#1109
Conversation
Adds 20 integration tests covering: - batch-evaluation CLI flag validation (requires --runtime, --evaluator) - run eval CLI flag validation - Evaluator lifecycle: SESSION, TRACE, TOOL_CALL levels, code-based (external lambda + managed), config file import - Online eval config lifecycle: builtin evaluator refs, enable-on-create, multiple evaluators, sampling rate - Evaluator validation edge cases: invalid level, --model with code-based, --lambda-arn without code-based - Ground truth file parsing: malformed JSON, wrong structure, valid array format, valid object format with sessionMetadata key Originally from private-agentcore-cli-staging PR #104.
Contributor
Coverage Report
|
|
The test A couple of other things worth noting about that same test:
Options to fix:
Could you confirm which direction is intended and update the test accordingly? |
The code-based evaluator restriction in OnlineEvalConfigPrimitive was already removed, so this test expected a rejection that no longer occurs.
Contributor
Author
|
addressed comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 20 integration tests covering batch evaluation, evaluator, and online eval config CLI lifecycle:
--runtimerequired,--evaluatorrequired--evaluatorrequired--modelwith code-based,--lambda-arnwithout code-basedOriginally from private-agentcore-cli-staging PR #104. Only the test file is needed — the code changes from that PR (remove code-based evaluator blocks, add test utils) are already on main.
Test plan
npm run test:integpasses (20 new tests)