Skip to content

test: remove http-gateway-targets e2e test#1090

Merged
Hweinstock merged 1 commit intomainfrom
fix/remove-http-gateway-targets-e2e
May 1, 2026
Merged

test: remove http-gateway-targets e2e test#1090
Hweinstock merged 1 commit intomainfrom
fix/remove-http-gateway-targets-e2e

Conversation

@jariy17
Copy link
Copy Markdown
Contributor

@jariy17 jariy17 commented May 1, 2026

Summary

  • Removes e2e-tests/http-gateway-targets.test.ts which was incorrectly testing MCP gateways using placeholder URLs
  • AWS::BedrockAgentCore::GatewayTarget with mcpServer type connects to the endpoint during CloudFormation CREATE to discover tools — placeholder URLs caused CREATE_FAILEDNoStack errors in CI
  • HTTP gateways are created through the AB test flow (agentcore add ab-test --mode target-based), not via agentcore add gateway. HTTP gateway coverage is provided by ab-test-target-based.test.ts

Test plan

  • Verify e2e-tests/ab-test-target-based.test.ts covers HTTP gateway deployment end-to-end
  • Confirm CI no longer fails with NoStack: CloudFormationStack object does not hold a stack on shard 3

🤖 Generated with Claude Code

HTTP gateways are created through the AB test flow (add ab-test --mode target-based),
not via agentcore add gateway. The standalone test was using MCP gateway commands
against placeholder URLs that caused AWS::BedrockAgentCore::GatewayTarget CREATE_FAILED
errors. HTTP gateway coverage is provided by ab-test-target-based.test.ts.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@jariy17 jariy17 requested a review from a team May 1, 2026 20:55
@Hweinstock
Copy link
Copy Markdown
Contributor

addresses first part of #1091

@github-actions github-actions Bot added size/m PR size: M agentcore-harness-reviewing AgentCore Harness review in progress labels May 1, 2026
@agentcore-cli-automation
Copy link
Copy Markdown

Reviewed the PR. The reasoning checks out:

  • Confirmed e2e-tests/ab-test-target-based.test.ts exercises HTTP gateway creation/deployment/teardown via the AB-test target-based flow (including a status assertion for resourceType === 'http-gateway' and remove ab-test --delete-gateway).
  • Confirmed integ-tests/add-remove-gateway.test.ts still covers the direct add gateway, add gateway-target, remove gateway-target, and remove gateway CLI commands.
  • Confirmed the root cause in agentcore-l3-cdk-constructs/src/cdk/constructs/components/mcp/Gateway.ts (lines 370–386): external mcpServer targets are deployed as CfnGatewayTarget with the raw endpoint, which AgentCore validates on CREATE — placeholder URLs will legitimately fail.
  • No other references to http-gateway-targets (no CI sharding config, no docs) — clean deletion.

LGTM.

@github-actions github-actions Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label May 1, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 42.89% 8936 / 20830
🔵 Statements 42.17% 9485 / 22491
🔵 Functions 39.66% 1537 / 3875
🔵 Branches 39.82% 5769 / 14486
Generated in workflow #2322 for commit 45a4009 by the Vitest Coverage Report Action

@Hweinstock Hweinstock merged commit 5ce1874 into main May 1, 2026
26 checks passed
@Hweinstock Hweinstock deleted the fix/remove-http-gateway-targets-e2e branch May 1, 2026 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/m PR size: M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants