fix: replace z.undefined() with z.never() for JSON Schema compat#1075
Merged
fix: replace z.undefined() with z.never() for JSON Schema compat#1075
Conversation
|
LGTM. The change is minimal and correct:
|
Contributor
Coverage Report
|
4d8bfe1 to
84a7b47
Compare
padmak30
previously approved these changes
May 1, 2026
84a7b47 to
03c7a0c
Compare
03c7a0c to
37846f6
Compare
padmak30
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Zod JSON Schema generation failure:
z.undefined()cannot be represented in JSON Schema.The AB test variant XOR union used
z.undefined().optional()to exclude the alternate field. Replace withz.never().optional()which Zod can serialize.Test plan
npm run buildpassesnode scripts/generate-schema.mjssucceeds