feat: wire telemetry into all remove.* commands

[Hweinstock]

Description

Wire telemetry withCommandRun() into all remove.* CLI command handlers and TUI remove flows, following the same pattern established in #1050 for add.* commands.

CLI paths use cliCommandRun which wraps the action handler with telemetry recording, error formatting, and process.exit. TUI paths use a new withTuiTelemetry helper (generalized from withAddTelemetry) that wraps each remove operation.

Supporting changes:

• withAddTelemetry generalized to withTuiTelemetry — works for any { success: boolean } result type (add, remove, etc.). withAddTelemetry kept as deprecated alias.
• remove.all added to COMMAND_SCHEMAS

All remove commands emit NoAttrs (no command-specific attributes per the telemetry metric shape spec).

Related Issue

N/A — continuation of #1050

Type of Change

• New feature

Testing

• I ran npm run test:unit and npm run test:integ
• I ran npm run typecheck
• I ran npm run lint

• Telemetry assertions added to existing integ tests (add-remove-resources.test.ts) verifying audit JSONL entries for remove.memory, remove.credential, and remove.policy-engine
• Manual verification: AGENTCORE_TELEMETRY_AUDIT=1 → confirmed success and failure entries in audit files

Checklist

• I have read the CONTRIBUTING document
• I have added any necessary tests that prove my fix is effective or my feature works
• I have updated the documentation accordingly
• I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
• My changes generate no new warnings
• Any dependent changes have been merged and published

---

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

[Hweinstock]

/strands review

[github-actions]

Additional Context on the Blocking Issue

To clarify: RuntimeEndpointPrimitive.ts is not modified in this PR, so the missing telemetry for remove.runtime-endpoint is a pre-existing gap, not introduced by this PR.

However, since:

1. The PR title states "wire telemetry into all remove.* commands"
2. remove.runtime-endpoint exists as a removable resource (has been since before this PR)
3. This PR is specifically about completing telemetry coverage for remove commands

...it would be most consistent to address remove.runtime-endpoint in this PR rather than leaving it as the one exception.

Options:

Option A (Recommended): Add RuntimeEndpointPrimitive.ts to this PR's scope

• Small change (~10 lines)
• Achieves the "all remove.* commands" goal stated in the PR
• Maintains consistency with the telemetry instrumentation effort

Option B: Explicitly document that remove.runtime-endpoint is out of scope

• Update PR title/description to clarify which commands are included
• Create a follow-up issue to track remove.runtime-endpoint telemetry

Let me know which approach you prefer!

[github-actions]

Overall Assessment

Code Quality: ✅ Excellent

This PR demonstrates strong software engineering practices:

1. Consistent pattern application - Follows the established telemetry instrumentation pattern from feat: wire telemetry into all add.* commands #1050
2. Clean refactoring - The generalization from withAddTelemetry to withTuiTelemetry is well-thought-out
3. Type safety - Proper use of TypeScript generics and type constraints
4. Test coverage - Integration tests verify the telemetry actually works
5. Documentation - Type casting is justified with safety comments

Architecture: ✅ Sound

The telemetry wiring correctly separates concerns:

• CLI paths → cliCommandRun (handles exit codes and error formatting)
• TUI paths → withTuiTelemetry (preserves result objects)
• Both paths record the same telemetry via withCommandRun

Completeness: ⚠️ One gap

The only issue is the remove.runtime-endpoint gap discussed above. Once that's addressed (or explicitly scoped out), this PR will be in excellent shape.

---

Great work overall! The implementation is solid and the pattern is maintainable. 🎉

[agentcore-cli-automation]

Reviewed the diff end-to-end and didn't find any merge-blocking issues. The CLI path refactor in BasePrimitive and RuntimeEndpointPrimitive preserves the original JSON output shape on both success and failure (via errorContext for the failure side), and the withTuiTelemetry generalization correctly handles both the fn()-throws and fn()-returns-failure cases. Typing of SubCommand<'remove', ResourceType> with CommandAttrs collapsing to {} for NoAttrs commands is sound.

One minor note (non-blocking): the PR description says withAddTelemetry is kept as a deprecated alias, but the symbol is actually fully removed — all internal callers were migrated. Either update the description or add the alias, but since nothing outside the package imports it, this isn't a real concern.

LGTM.