chore(deps): override glob to ^13 to silence install deprecation warning#1008
Open
minorun365 wants to merge 1 commit intoaws:mainfrom
Open
chore(deps): override glob to ^13 to silence install deprecation warning#1008minorun365 wants to merge 1 commit intoaws:mainfrom
minorun365 wants to merge 1 commit intoaws:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
npm install -g @aws/agentcorecurrently emits an npm deprecation warning aboutglob@10.5.0, pulled in transitively viaarchiver-utils@5.0.2:archiver-utils@latest(5.0.2) still requiresglob@^10.0.0, so this cannot be fixed at the source. The npm registry currently marksglob@<12as deprecated; onlyglob@>=12is free of the warning.This PR adds a
glob: "^13.0.0"entry topackage.json#overrides, following the same pattern already used in this repo forminimatch,fast-xml-parser, and@aws-sdk/xml-builder. After this change,npm installruns with zero deprecation warnings.Verification:
archiver-utils@5.0.2only usesglob.sync(pattern, options), which remains a stable API inglob@13(verified by inspectingarchiver-utils/file.js).glob@13's own dependencyminimatch ^10.2.2is compatible with the existingminimatch: 10.2.4override.npm installno longer emits any deprecation warnings (verified locally).overridesCommentsdocuments that the override should be removed oncearchiver-utilsupdates itsglobdependency, mirroring the existing comments for the other overrides.Both
main(v0.12.0) andpreview(v1.0.0-preview.3) carry the samepackage.jsonoverrides structure and are equally affected. This PR targetsmainonly, since dependency-related changes flow intopreviewvia the project's existingmain → previewmerge cadence (consistent with how Dependabot PRs are handled in this repo).Related Issue
Closes #1007
Documentation PR
N/A — no user-facing API changes.
Type of Change
Testing
How have you tested the change?
npm installlocally and confirmed theglob@10.5.0deprecation warning no longer appears.npm run typecheckpasses (also verified by the husky pre-commit hook).npm run lintpasses with no new warnings.npm run test:unit(afternpm run build). All tests pass except 2 pre-existing failures insrc/cli/commands/dev/__tests__/dev.test.ts(positional prompt invokecases), which reproduce identically onupstream/mainwithout this change and are unrelated to thegloboverride.npm run test:integ— relying on CI to exercise integration tests against this dependency-only change.src/assets/, I rannpm run test:update-snapshots— N/A (no asset changes).Checklist
overridesCommentsentry added).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.