Skip to content

chore(deps): override glob to ^13 to silence install deprecation warning#1008

Open
minorun365 wants to merge 1 commit intoaws:mainfrom
minorun365:fix/glob-deprecation-warning-main
Open

chore(deps): override glob to ^13 to silence install deprecation warning#1008
minorun365 wants to merge 1 commit intoaws:mainfrom
minorun365:fix/glob-deprecation-warning-main

Conversation

@minorun365
Copy link
Copy Markdown

@minorun365 minorun365 commented Apr 29, 2026

Description

npm install -g @aws/agentcore currently emits an npm deprecation warning about glob@10.5.0, pulled in transitively via archiver-utils@5.0.2:

npm warn deprecated glob@10.5.0: Old versions of glob are not supported, ...

archiver-utils@latest (5.0.2) still requires glob@^10.0.0, so this cannot be fixed at the source. The npm registry currently marks glob@<12 as deprecated; only glob@>=12 is free of the warning.

This PR adds a glob: "^13.0.0" entry to package.json#overrides, following the same pattern already used in this repo for minimatch, fast-xml-parser, and @aws-sdk/xml-builder. After this change, npm install runs with zero deprecation warnings.

Verification:

  • archiver-utils@5.0.2 only uses glob.sync(pattern, options), which remains a stable API in glob@13 (verified by inspecting archiver-utils/file.js).
  • glob@13's own dependency minimatch ^10.2.2 is compatible with the existing minimatch: 10.2.4 override.
  • npm install no longer emits any deprecation warnings (verified locally).

overridesComments documents that the override should be removed once archiver-utils updates its glob dependency, mirroring the existing comments for the other overrides.

Both main (v0.12.0) and preview (v1.0.0-preview.3) carry the same package.json overrides structure and are equally affected. This PR targets main only, since dependency-related changes flow into preview via the project's existing main → preview merge cadence (consistent with how Dependabot PRs are handled in this repo).

Related Issue

Closes #1007

Documentation PR

N/A — no user-facing API changes.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Testing

How have you tested the change?

  • I ran npm install locally and confirmed the glob@10.5.0 deprecation warning no longer appears.
  • npm run typecheck passes (also verified by the husky pre-commit hook).
  • npm run lint passes with no new warnings.
  • I ran npm run test:unit (after npm run build). All tests pass except 2 pre-existing failures in src/cli/commands/dev/__tests__/dev.test.ts (positional prompt invoke cases), which reproduce identically on upstream/main without this change and are unrelated to the glob override.
  • I ran npm run test:integ — relying on CI to exercise integration tests against this dependency-only change.
  • If I modified src/assets/, I ran npm run test:update-snapshots — N/A (no asset changes).

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works — N/A for a transitive-dep override.
  • I have updated the documentation accordingly (overridesComments entry added).
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed (no new docs needed for a transitive-dep override).
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@minorun365 minorun365 requested a review from a team April 29, 2026 04:59
@github-actions github-actions Bot added the size/xs PR size: XS label Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

npm install emits deprecation warning for glob@10.5.0 (transitive via archiver-utils)

1 participant