Skip to content

feat: add agentcore art command#1000

Open
jesseturner21 wants to merge 3 commits intomainfrom
feat/art-command
Open

feat: add agentcore art command#1000
jesseturner21 wants to merge 3 commits intomainfrom
feat/art-command

Conversation

@jesseturner21
Copy link
Copy Markdown
Contributor

Summary

  • Adds agentcore art command that displays the AgentCore brain logo as ASCII art
  • Adds hidden Moab team credit in README

Test plan

  • Run agentcore art and verify ASCII brain renders in cyan

@jesseturner21 jesseturner21 requested a review from a team April 28, 2026 19:05
@github-actions github-actions Bot added the size/s PR size: S label Apr 28, 2026
@github-actions github-actions Bot added the agentcore-harness-reviewing AgentCore Harness review in progress label Apr 28, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Package Tarball

aws-agentcore-0.11.0.tgz

How to install

npm install https://github.com/aws/agentcore-cli/releases/download/pr-1000-tarball/aws-agentcore-0.11.0.tgz

@agentcore-cli-automation
Copy link
Copy Markdown

Hidden "Made by the Moab team" comment in README

This adds an internal team credit (as a hidden HTML comment) to an AWS-maintained open-source project's README. That feels out of place for an aws/* OSS repo — individual team attributions aren't really standard here, even hidden ones, and it's the kind of thing that tends to get flagged later.

Options:

  • Drop the README change from this PR entirely.
  • If you want to credit contributors, use the standard CONTRIBUTORS / AUTHORS mechanism rather than a hidden comment.
  • Run it past whoever owns README/branding policy for this repo before merging.

@agentcore-cli-automation
Copy link
Copy Markdown

art command is not hidden — it will show up in the TUI home screen and --help

If this is intended as an easter egg (which the PR framing suggests), it isn't actually hidden:

  1. getCommandsForUI in src/cli/tui/utils/commands.ts filters by the HIDDEN_FROM_TUI list (['help', 'telemetry']). Because art isn't in that list, it will appear in the home-screen command list users see when running agentcore with no args.
  2. The command is registered without { hidden: true }, so it will also appear in commander's agentcore --help output and in suggestion lists.

To make it a real easter egg, you'll want both:

  • Add 'art' to HIDDEN_FROM_TUI in src/cli/tui/utils/commands.ts.
  • Register the command with .command('art', { hidden: true }) (or call .hidden() on it) in src/cli/commands/art/command.tsx so it's hidden from commander help output too.

If it's not meant to be hidden, then per the convention in src/cli/tui/copy.ts the description should live in COMMAND_DESCRIPTIONS alongside every other command, and the PR description wording ("hidden Moab team credit") should be updated.

@github-actions github-actions Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Apr 28, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 28, 2026

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines Unknown% 0 / 0
🔵 Statements Unknown% 0 / 0
🔵 Functions Unknown% 0 / 0
🔵 Branches Unknown% 0 / 0
Generated in workflow #2063 for commit 9d15a63 by the Vitest Coverage Report Action

@github-actions github-actions Bot added size/s PR size: S and removed size/s PR size: S labels Apr 28, 2026
@github-actions github-actions Bot added size/s PR size: S and removed size/s PR size: S labels Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants