ci: hold cdk-nag and @types/node major bumps in Dependabot#276
Merged
Conversation
Add ignore rules to the root npm ecosystem so Dependabot stops proposing major version bumps for two dependencies (minor/patch updates still flow): - cdk-nag: v3 is a breaking rewrite (IAspect -> IPolicyValidationPlugin, and NagSuppressions -> per-finding Validations.acknowledge). Deferred until upstream supports prefix/bulk acknowledgment. This is why the grouped npm PR #275 fails "Validate CDK synthesis" — the ignore drops the v3 bump so a regenerated PR builds. Unignore when ready to do the v3 migration. - @types/node: keep aligned with the Node.js runtime major we target (currently 24) rather than chasing the newest typings.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
Scan for commit: 🔒 Security Scan ResultsScanned files: 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ignore rules to the root npm ecosystem so Dependabot stops proposing major version bumps for two dependencies (minor/patch updates still flow):
What does this PR do?
🛑 Please open an issue first to discuss any significant work and flesh out details/direction — we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
Motivation
Type of Change
Testing
npm run buildsuccessfullynpm run testand all tests passnpx cdk synthwith a sample.env(e.g. fromblueprints/dummy/samples/) and it succeedsnpm run run-pre-commitNew Blueprint Checklist (if adding a protocol)
blueprints/dummy/(reference implementation).envfiles are provided for at least one network (mainnet or testnet)blueprints/dummy/)website/docs/blueprints/(.mdx mirror importing README)Documentation
cd website && npm run buildwith no broken links (if docs changed)License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.