ci(website): move Pages deploy to Node 24 actions and runtime#272
Merged
Conversation
The first-party Pages deploy failed ("Deployment failed, try again later") and
warned that configure-pages@v5 / upload-artifact@v4 target the deprecated
Node 20 and were force-run on Node 24. Move the website workflows off Node 20:
- actions/configure-pages v5 -> v6
- actions/upload-pages-artifact v3 -> v5
- actions/deploy-pages v4 -> v5
- setup-node node-version 20 -> 24 in both website-deploy.yaml and
website-test-deploy.yml
Node 24 is the current active LTS and the version the site build was verified
on locally. This clears the Node 20 deprecation warning and moves deploy-pages
onto a Node 24-compatible release. A lingering "try again later" is a
transient/wedged Pages deploy and clears on a workflow re-run.
Dependency ReviewThe following issues were found:
License Issues.github/workflows/website-deploy.yaml
OpenSSF Scorecard
Scanned Files
|
|
Scan for commit: 🔒 Security Scan ResultsScanned files: 2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first-party Pages deploy failed ("Deployment failed, try again later") and warned that configure-pages@v5 / upload-artifact@v4 target the deprecated Node 20 and were force-run on Node 24. Move the website workflows off Node 20:
Node 24 is the current active LTS and the version the site build was verified on locally. This clears the Node 20 deprecation warning and moves deploy-pages onto a Node 24-compatible release. A lingering "try again later" is a transient/wedged Pages deploy and clears on a workflow re-run.
What does this PR do?
🛑 Please open an issue first to discuss any significant work and flesh out details/direction — we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
Motivation
Type of Change
Testing
npm run buildsuccessfullynpm run testand all tests passnpx cdk synthwith a sample.env(e.g. fromblueprints/dummy/samples/) and it succeedsnpm run run-pre-commitNew Blueprint Checklist (if adding a protocol)
blueprints/dummy/(reference implementation).envfiles are provided for at least one network (mainnet or testnet)blueprints/dummy/)website/docs/blueprints/(.mdx mirror importing README)Documentation
cd website && npm run buildwith no broken links (if docs changed)License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.