fix(claude-apps-gateway): PR #282 doc follow-ups; fix stale Desktop-default comment - #283
Open
bsnehanshu wants to merge 1 commit into
Open
bsnehanshu wants to merge 1 commit into
bsnehanshu wants to merge 1 commit into
Conversation
…efault comment Three defects left over from #282 (chore(claude-apps-gateway): bump pinned Claude Code to 2.1.229; Opus 5 as the catalog default), all in text/examples the diff's own hunks didn't cover: - README.md:246 linked docs/gotchas.md#20-three-ways-the-desktop-block-itself-bites, but the target heading's `**[hit live]**` suffix makes GitHub's actual slug end in `--hit-live` (double hyphen, matching the repo's existing #13-config-is-baked--the-image-is-per-environment precedent). The link landed at the top of the file instead of the gotcha it was meant to point at. - docs/deployment.md:43-44 read "...au., plus\nand jp. for some models..." — an orphaned "plus" left over when the jp. clause was reworded. - cdk/README.md's local-dev example and README.md's failover example still shipped claude-opus-4-8, directly contradicting the "shipped catalog is Claude Opus 5..." line #282 added earlier in the same file. Also fixes a related but separate bug in claude-apps-gateway-bootstrap: the comment above the chatTabEnabled passthrough claimed omitting a toggle "keeps the client default" for all three surface toggles. That's true for coworkTabEnabled/isClaudeCodeForDesktopEnabled (show unless false) but wrong for chatTabEnabled, which is hidden unless explicitly set true per the gateway README's Desktop overlay table. The example config only set 1 of 3 toggles as a result; now sets all three explicitly. Verified: shellcheck clean, setup-helpers.test.sh 19/19, stamp-config.test.sh 9/9, node --check on server.js, bootstrap authorize.test.mjs 5/5, no remaining 2.1.218/claude-opus-4-8 references in claude-apps-gateway/.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Three defects left over from #282, all in text/examples the diff's own hunks didn't cover, plus one related bug found independently in
claude-apps-gateway-bootstrap.In
claude-apps-gateway/:README.md:246— the link todocs/gotchas.md#20-three-ways-the-desktop-block-itself-biteswas missing GitHub's actual slug suffix. The target heading is## 20. Three ways the desktop block itself bites **[hit live]**, and the double space before the bold marker produces a double-hyphen slug (--hit-live), matching the repo's existing precedent atdocs/gotchas.md#13-config-is-baked--the-image-is-per-environment. The link landed at the top of the file instead of the gotcha it pointed to.docs/deployment.md:43-44— an orphaned "plus" left over from rewording thejp.clause: "...au., plus\nand jp. for some models...".cdk/README.mdandREADME.mdstill shippedclaude-opus-4-8in two example blocks (cdk/README.md's local-dev example,README.md's failover example), directly contradicting the "shipped catalog is Claude Opus 5..." line chore(claude-apps-gateway): bump pinned Claude Code to 2.1.229; Opus 5 as the catalog default #282 added earlier in the same files.In
claude-apps-gateway-bootstrap/(pre-existing, unrelated to #282):The comment above the
chatTabEnabledpassthrough inserver.jsclaimed omitting any of the three Desktop surface toggles "keeps the client default." True forcoworkTabEnabled/isClaudeCodeForDesktopEnabled(show unlessfalse), false forchatTabEnabled(hidden unless explicitlytrue, per the gateway README's Desktop overlay table). The example config set only 1 of the 3 toggles as a result — now sets all three explicitly, and the comment states the asymmetry.Why
All four are mechanical — no design judgment involved, just checking that changed lines are consistent with the rest of the file/repo they live in, not just internally correct. Caught in an independent second-pass review after #282 merged.
Verification
shellcheck cdk/scripts/setup.sh— clean./test/setup-helpers.test.sh— 19/19./test/stamp-config.test.sh— 9/9node --checkonbootstrap/server.js— cleannode --test test/authorize.test.mjs(bootstrap) — 5/5grep -rn "2\.1\.218\|claude-opus-4-8"acrossclaude-apps-gateway/— no remaining hits outside two pre-existing, out-of-scope refs (README.md:174,352, predate chore(claude-apps-gateway): bump pinned Claude Code to 2.1.229; Opus 5 as the catalog default #282, left alone)🤖 Generated with Claude Code