feat(cinema4d-2025): Add Plugin Sync activate/deactivate scripts#223
feat(cinema4d-2025): Add Plugin Sync activate/deactivate scripts#223diane-hj wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
waiting-on-maintainers
seant-aws
left a comment
seant-aws
left a comment
There was a problem hiding this comment.
Should we change the conda recipe readme for cinema4d too ?
karthikbekalp
left a comment
karthikbekalp
left a comment
There was a problem hiding this comment.
Let's discuss about supporting Linux conda recipe package offline.
| context: | ||
| version_major: "2025" | ||
| version_minor: "3" | ||
| version_patch: "1" | ||
|
|
There was a problem hiding this comment.
A little out of scope, but have we tried this recipe with latest Cinema 4D 2026? 2025 is quite old.
| @@ -0,0 +1,3 @@ | |||
| #!/bin/bash | |||
| # Plugin Sync for Cinema 4D — deactivate script | |||
| # No-op: g_additionalModulePath is already unset by the main cinema4d-*-vars.sh deactivate script. | |||
There was a problem hiding this comment.
Do we need this file if there's no op?
There was a problem hiding this comment.
Agree, we should remove as this is dead code and not needed
| sourceArchiveFilename: Cinema4D_2025_2025.3.1_Linux.zip | ||
| sourceDownloadInstructions: 'Download the Cinema4D 2025 Linux installer from Maxon and place it in the archive_files directory.' | ||
| buildTool: rattler-build |
There was a problem hiding this comment.
Hmm, wait. I don't think we have a conda recipe for Linux for Cinema 4D. Let's discuss about this offline.
There was a problem hiding this comment.
I believe we do have it for Linux for 2025 and 2026? https://docs.aws.amazon.com/deadline-cloud/latest/userguide/maxon-cinema-4d.html
karthikbekalp
removed
the
waiting-on-maintainers
| echo "Plugin Sync: Downloading generic plugins from $_SP_GENERIC_SRC" | ||
| mkdir -p "$_SP_GENERIC_DIR" | ||
| if ! aws s3 cp "$_SP_GENERIC_SRC" "$_SP_GENERIC_DIR/" --recursive --quiet; then | ||
| echo "Plugin Sync: WARNING — Failed to download generic plugins from $_SP_GENERIC_SRC" >&2 |
There was a problem hiding this comment.
The download failures are warned silently here, do we want to use uses 2>/dev/null || true like how we do above ?
…Windows Add plugin sync support for Cinema 4D 2025 on Windows (conda-build). On conda activate, the script downloads plugin files from the job attachment S3 bucket and prepends the download directory to g_additionalModulePath.
diane-hj
force-pushed
the
cinema4d-plugin-sync
branch
from
1eaf8f4 to
beaa29c
Compare
5 participants
Add plugin sync support for Cinema 4D on Linux. On conda activate, the script downloads plugin files from the job attachment S3 bucket and prepends the download directory to g_additionalModulePath.
What was the problem/requirement? (What/Why)
Customers want a simple "drag and drop files to S3" experience instead of learning Conda packaging. This implements the Cinema 4D portion of the Plugin Sync feature, following the same pattern as Maya (#210) and Nuke (#220).
What was the solution? (How)
Added
zzz-cinema4d-plugin-sync-activate.shandzzz-cinema4d-plugin-sync-deactivate.shto the Cinema 4D 2025 conda recipe. On conda activate, the script:What is the impact of this change?
Customers can upload Cinema 4D plugin files (.pyp, etc.) to their job attachment S3 bucket and have them automatically available on workers before Cinema 4D launches. No Conda packaging knowledge required.
How was this change tested?
Was this change documented?
yes
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.