feat(vray): Add pre-submission hook for vrscene asset discovery#209
Open
rickrams wants to merge 2 commits into
Open
feat(vray): Add pre-submission hook for vrscene asset discovery#209rickrams wants to merge 2 commits into
rickrams wants to merge 2 commits into
Conversation
Add a pre-submission hook that parses vrscene files to automatically discover and attach referenced textures and files to job submissions. The hook extracts file paths from: - file="..." parameters (BitmapBuffer textures, GeomMeshFile meshes, etc.) - #include "..." directives for referenced vrscene files Relative paths are resolved against the vrscene directory. Missing files are logged as warnings but do not block submission. New files: - hooks.yaml: Pre-submission hook configuration - scripts/discover_vrscene_assets.py: Asset discovery script Updated files: - template.yaml: Updated VraySceneFile description - README.md: Added hook documentation and updated bundle structure Signed-off-by: rickrams <rickrams@users.noreply.github.com>
github-actions
Bot
added
the
waiting-on-maintainers
crowecawcaw
reviewed
Apr 27, 2026
| @@ -0,0 +1,5 @@ | |||
| version: "1.0" | |||
| preSubmission: | |||
| - command: python3 | |||
Contributor
There was a problem hiding this comment.
Nit: python3 probably won't work on Windows. Maybe we want to make commands configurable by OS for hooks in the future.
crowecawcaw
previously approved these changes
Apr 27, 2026
crowecawcaw
previously approved these changes
Apr 28, 2026
V-Ray appends the frame number before the extension when using -frames (e.g., output_f10_region_r0_c0.0010.png instead of output_f10_region_r0_c0.png). The merge step expects the filename without the frame number insertion. Rename V-Ray's actual output to the expected name after rendering so multi-frame renders work correctly. Signed-off-by: rickrams <rickrams@users.noreply.github.com>
rickrams
force-pushed
the
feat/vrscene-asset-discovery-hook
branch
from
d732e33 to
d55531a
Compare
Contributor
Author
|
added a fix for frame names for multi-frame renders but otherwise good to go! |
leon-li-inspire
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a pre-submission hook that parses vrscene files to automatically discover and attach referenced textures and files to job submissions.
The hook extracts file paths from:
Relative paths are resolved against the vrscene directory. Missing files are logged as warnings but do not block submission.
New files:
Updated files:
Fixes:
How was this change tested?
Ran with two different vrscene files confirming it found all additional files, added them as job attachments, and the resulting render worked.
Was this change documented?
yes
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.