Add WithDirection style + port_directions query#227
Open
gpeairs wants to merge 10 commits into
Open
Conversation
gpeairs
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Adds a `WithDirection <: GeometryEntityStyle` style that annotates any
`GeometryEntity` with a direction angle (CCW from +X in local frame),
and a `port_directions(sch::Schematic, ly::Symbol) -> Dict{Int, String}`
query that extracts Palace-compatible `Direction` strings for indexed
entities on layer `ly` that carry the style.
Minor fixes, simplify tests
gpeairs
force-pushed
the
gp/lumped-direction
branch
from
7148613 to
0211db6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #52. Adds a
WithDirection <: GeometryEntityStylestyle that annotates anyGeometryEntitywith a direction angle (CCW from +X in local frame), and aport_directions(sch::Schematic, ly::Symbol) -> Dict{Int, String}query that extracts Palace-compatibleDirectionstrings for indexed entities on layerlythat carry the style.