Skip to content

Nova 4 Complete Update#12

Open
ali-raza-saleem wants to merge 8 commits into
awesome-nova:masterfrom
ali-raza-saleem:nova-4
Open

Nova 4 Complete Update#12
ali-raza-saleem wants to merge 8 commits into
awesome-nova:masterfrom
ali-raza-saleem:nova-4

Conversation

@ali-raza-saleem

Copy link
Copy Markdown

No description provided.

@ghost

ghost commented Apr 13, 2023

Copy link
Copy Markdown

UP !! We need this 😄

@tumainimosha tumainimosha mentioned this pull request Oct 23, 2023

@marcoraddatz marcoraddatz left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great PR! Many thanks for your work! Too bad, that this repo doesn't seem to get updated.

I noticed one little thing, which is only cosmetically. Feel free to change or keep it as it is.

class="py-4 px-8 focus:outline-none flex-1"
:class="[
isActive(option)
? 'border-b-2 border-primary-500 text-primary-500 bold'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
? 'border-b-2 border-primary-500 text-primary-500 bold'
? 'border-b-2 border-primary-500 text-primary-500 font-bold'

"bold" didn't work for me, but "font-bold" does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants