Skip to content

feat: php8 compatible #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
770studio wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: php8 compatible #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions src/Filters/DependentFilter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@

namespace AwesomeNova\Filters;

use Illuminate\Database\Eloquent\Builder;
use Illuminate\Http\Request;
use Illuminate\Support\Collection;
use Illuminate\Support\Str;
use Laravel\Nova\Filters\Filter;

Expand Down Expand Up @@ -60,10 +62,10 @@ public function __construct($name = null, $attribute = null)
/**
* Apply the filter to the given query.
*
* @param \Illuminate\Http\Request $request
* @param \Illuminate\Database\Eloquent\Builder $query
* @param mixed $value
* @return \Illuminate\Database\Eloquent\Builder
* @param Request $request
* @param Builder $query
* @param mixed $value
* @return Builder
*/
public function apply(Request $request, $query, $value)
{
Expand All @@ -87,9 +89,9 @@ public function key()
/**
* Get the filter's available options.
*
* @param \Illuminate\Http\Request $request
* @param array $filters
* @return array|\Illuminate\Support\Collection
* @param Request $request
* @param array $filters
* @return array|Collection
*/
public function options(Request $request, array $filters = [])
{
Expand All @@ -112,8 +114,8 @@ final public function dependentOf($filter)
}

/**
* @param \Illuminate\Http\Request $request
* @param array $filters
* @param Request $request
* @param array $filters
* @return array
*/
final public function getOptions(Request $request, array $filters = [])
Expand Down Expand Up @@ -198,7 +200,7 @@ public function hideWhenEmpty($value = true)
*
* @return array
*/
public function jsonSerialize()
public function jsonSerialize(): array
{
return array_merge([
'class' => $this->key(),
Expand Down