Repository navigation
fix: resolve mypy type errors in decomposition, utils, and viz - #1
Merged
Merged
Conversation
- Cast numpy arrays from torch.detach().cpu().numpy() and safetensors load to ndarray. - Use Sized protocol for jl_track iterable length check. - Convert np.arange tick indices to plain Python ints for matplotlib set_xticks/set_yticks. - Cast arithmetic operands around np.linalg.norm results to float to satisfy mypy. All mypy, ruff, and fast tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the remaining mypy errors in
jspace/decomposition.py,jspace/utils.py, andjspace/viz.py.Changes:
torch.detach().cpu().numpy()andsafetensorstonp.ndarray.Sizedprotocol for thejl_trackiterable length check instead ofhasattr.np.arangetick indices to plain Python ints before passing to matplotlib'sset_xticks/set_yticks.np.linalg.normresults and operands tofloatso mypy accepts the arithmetic.Verification:
mypy jspacepasses with no issues.ruff check jspace tests scriptspasses.pytest tests/test_security.py tests/test_bugfixes.py tests/test_cli.pypasses (23 tests).