Fix failing "timeout scenarios" tests in keepsorted.test.ts - #14
Merged
Conversation
Co-authored-by: awalsh128 <2087466+awalsh128@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job 'test'
Fix failing "timeout scenarios" tests in keepsorted.test.ts
Aug 22, 2026
… host in tests Co-authored-by: awalsh128 <2087466+awalsh128@users.noreply.github.com>
Owner
|
@copilot iterate on fixes to eventually pass CI workflow |
Co-authored-by: awalsh128 <2087466+awalsh128@users.noreply.github.com>
Contributor
Author
Fixed three more failing tests found in the CI logs for the PR branch:
Commit: fix: correct 3 failing test assertions in extension and completion tests |
Co-authored-by: awalsh128 <2087466+awalsh128@users.noreply.github.com>
awalsh128
marked this pull request as ready for review
August 22, 2026 05:03
Copilot stopped work on behalf of
awalsh128 due to an error
August 22, 2026 05:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three tests added under the
"timeout scenarios"describe block had assertions that contradicted both the implementation and the existing test suite — they expectedlintDocument/fixDocumentto not throw in error conditions where the code always throws.Changes
should handle error with non-zero exit code gracefully— exit code 1 with non-JSON stdout causesJSON.parse()to fail insidegetFindings(); updated to expectthrow /Failed to parse command output/should handle null exit code with signal gracefully—signal: "SIGTERM"causesspawnCommand()to throw; updated to expectthrow /SIGTERM/should handle spawn errors gracefully— stubbingspawnSyncto throw directly propagates uncaught since there's no try-catch wrapper; updated to expectthrow /ENOENT/All three fixes align with the behavior already verified by the existing
lintDocument/fixDocumenttests (e.g."should throw detailed error when process exits by signal","should throw detailed error when process spawn returns error").