Repository navigation
ACP page loads Patreon button image from an external URL on every view #200
Description
Summary
adm/style/acp_recenttopics.html loads the "Become a Patron" button image directly from Patreon's CDN:
<img src="https://c5.patreon.com/external/logo/become_a_patron_button.png" ...>Every time an admin opens this ACP page, their browser makes a direct request to c5.patreon.com. Bundling the button image with the extension's own assets avoids that external request (privacy/reliability: no third-party call on every ACP page view, and the button keeps working if Patreon changes/removes that asset URL).
Location
avathar/recenttopics/adm/style/acp_recenttopics.html, line ~174
Fix
Bundle a local copy of the Patreon button image under the extension's own asset path and reference it there instead of the external c5.patreon.com URL.
Activity
avandenberghe commentedon Oct 4, 2026
Follow-up to #212: the new
test_patreon_button_is_bundledusedmime_content_type(), which needs ext/fileinfo, and failed on the PHP 8.1 Windows CI job after the merge (develop33@ f2fcab8). Fixed in 5631b9b, which checks the PNG with coregetimagesize()instead. That commit went todevelop33directly rather than through a PR, and the maintainer chose to keep it. CI ondevelop33@ 5631b9b is green (24 passed, 1 skipped).