Skip to content

Give the footer navbar the nav-footer class, matching prosilver #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avandenberghe merged 1 commit into from
Oct 4, 2026
Merged

Give the footer navbar the nav-footer class, matching prosilver #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions contrib/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ Version history for the [PBTech style for phpBB](../README.md).

3.0.29 (04-10-2026)
- fixed the broken markup on the reply button above the posts in a topic: its `title` attribute ran over several lines, contained an unescaped `<span>` in locked topics and closed early with a stray `</span>`, and the label left a `<span>` unclosed in locked topics and emitted an unmatched `</span>` otherwise, breaking the DOM of the top action bar on every topic page - the button now matches the one in the bottom action bar ([#63](https://github.com/avatharbe/PBTech/issues/63))
- the footer navbar reused the header's `nav-main` ID and class, so every page carried a duplicate ID and phpBB's `forum_fn.js` treated the footer as the main navigation, skipping its responsive menu on narrow screens - the footer now uses `nav-footer`, as in prosilver ([#64](https://github.com/avatharbe/PBTech/issues/64))
- removed two stylesheet links left over from PBWoW in `simple_header.html`: `pbwow.css` and `responsive.css` are not part of PBTech, so every popup - smilies, member search, report dialogs - made two requests that returned 404 ([#65](https://github.com/avatharbe/PBTech/issues/65))
- moved the inline JavaScript in `overall_footer.html` - collapsible stat blocks, mini-profile dropdowns, tooltip replacement and the anchor offset - to `template/pbtech.js`, so browsers can cache it instead of downloading it again with every page ([#66](https://github.com/avatharbe/PBTech/issues/66))
- stopped printing pbwowext's custom header links from `navbar_header.html`: the style template depended on one specific extension, which phpBB's style review rejects - pbwowext 3.3.3 now renders them through the `overall_header_navigation_append` event, so update pbwowext together with this style or the links disappear ([#68](https://github.com/avatharbe/PBTech/issues/68))
Expand Down
2 changes: 1 addition & 1 deletion template/navbar_footer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<div class="navbar_footer" role="navigation">
<div class="inner">

<ul id="nav-footer" class="nav-main linklist" role="menubar">
<ul id="nav-footer" class="nav-footer linklist" role="menubar">
<li class="small-icon icon-home breadcrumbs {% if S_IS_LOCKED %} locked{% endif %}">
{% if U_SITE_HOME %}
<span class="crumb">
Expand Down
Loading