Repository navigation
Enable a focused desktop dashboard on landscape iPads - #57
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 11-inch iPad Pro now gets the desktop schedule sidebar and inline game details in landscape. The dashboard activates at 1,152px (72rem), covering both 1,194px and 1,210px landscape widths; portrait retains the single-column layout.
Selecting a game collapses the redundant right-hand overview and brings its details to the top. The sidebar centers the matching game, marks it as “Viewing details,” and preserves usable keyboard focus when the selected card hides. Closing details restores the overview. Games can be switched directly from the sidebar, and live refreshes leave manual scrolling alone. Rotating into landscape also reveals the selected sidebar game.
The CSS layout and JavaScript dialog selection share the same breakpoint. Regression tests cover breakpoint boundaries, independent scrolling, sticky layout, control fit, close behavior, selection through rotation, collapse/reopen, keyboard focus, and game switching. The existing dialog-sizing test uses portrait and waits for the entrance animation before measuring.
Validation: