misc bug fixes#42
Merged
Merged
Conversation
When an Undo Block arrives for a block that was never received or already deleted, silently ignore it instead of raising DoesNotExist. This is a normal federation race condition.
When a remote server returns a non-UTF-8 error page (e.g. 502), response.json() raises UnicodeDecodeError. Catch it alongside JSONDecodeError.
Add a get_object_or_404 wrapper that catches ValueError/TypeError from invalid PK types (e.g. UUIDs passed where integers are expected) and returns 404 instead of crashing with a 500 error. Update all API view imports to use the wrapper.
410 Gone indicates a resource is permanently gone. Retrying delivery to such an inbox will never succeed. Treat 410 like 404 by not raising ValueError, allowing the fan_out state machine to transition to sent instead of retrying. Fixes EGGPLANT-15F Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not really bug fixes but so that the server won't spit out 500s