Repository navigation
fix: turn main's Backend tests green (3 fixes #75 did not carry) - #78
Merged
Merged
Conversation
cancel_career_task already cancels a career task's live worker; the follow-up _cancel_task_objects cancelled it again. The second cancel could land inside the worker's final awaited DB commit, orphaning an open SQLite write transaction (RESERVED lock) so the reset's checkpoint hit 'database is locked' after the 30s busy timeout. Flaky on main too. Skip tasks that already have a pending cancellation; still await them. (cherry picked from commit b15017f56941cf75c7fcd4ccaea5a557fe4b20d7)
…firmed Confirming every resume decision group left the proposal 'in_review' with no accepted ResumeVersion. A confirmed decision-plan node now finalizes the proposal in the same review transaction once no change is pending: snapshot the workspace as a ResumeVersion and mark it accepted through mark_workspace_proposal_accepted, the helper now shared with create_resume_version_record (all-rejected closes it as 'rejected'). Idempotent, and a replayed final review finalizes a fully reviewed but unfinalized proposal. Direct workspace reviews keep the existing contract: the proposal stays open until the user saves a version. Drop the strict xfail on test_tailor_resume_fixture_runs_ask_plan_receipts_and_workspace_on_one_run. (cherry picked from commit 42203d951c84987cf42d2d4d2ccd61a31e969482)
…shared DB order leak) (cherry picked from commit 5da56feb4e06495782e8662759ea0e11c40d1e0e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: turn main's Backend tests green (3 fixes #75 did not carry)
Base: main 9aaac1a. Local full backend suite after these 3 commits: 1088 passed, 2 skipped, 0 failed (main alone: 4 failed / 1084 passed).
_quiesce_active_workcancelled the same worker twice (cancel_career_task+_cancel_task_objects). When the second cancel landed during a commit, the worker abandoned a SQLite write transaction while still holding RESERVED. The nextBEGIN IMMEDIATEthen waited 30 s and failed with "database is locked". The failure is intermittent and also happens on main. Fix: skipcancel()for tasks that are alreadycancelling(), but still await them. Fixestest_local_data_reset::test_registry_confirmed_reset_....in_reviewtoaccepted(if at least one change was accepted) or torejected(if all were rejected). In the same transaction it creates a ResumeVersion and setscurrent_version_id. The operation is idempotent and replay-safe. The shared helpersproposal_fully_reviewedandmark_workspace_proposal_acceptedlive inresume_versions.py, andcreate_resume_version_recordnow reuses them. The manual workspace review route is unchanged. Fixestest_tailor_resume_fixture_runs_ask_plan_receipts_and_workspace_on_one_run.rows[0]picked up another test's event. These tests failed only in full-suite order.