Skip to content

Download binaries from vim - #920

Open
abitrolly wants to merge 3 commits into
autozimu:devfrom
abitrolly:download-binaries
Open

abitrolly wants to merge 3 commits into
autozimu:devfrom
abitrolly:download-binaries

Conversation

@abitrolly

Copy link
Copy Markdown

:LanguageClientInstallBinaries makes it easy to download or refresh languageclient. This is my first time writing vimscript and I just wrapped provided install.sh.

@autozimu

autozimu commented Dec 2, 2019

Copy link
Copy Markdown
Owner

What are the benefits of providing this extra command than relying on plugin manager like plug or dein to do the work automatically? If the user needs to do the download one time occasionally, it should be easy enough to fire off the command in terminal.

@abitrolly

Copy link
Copy Markdown
Author

@autozimu I don't use plugin managers with Vim 8, because it is able to discover and run plugin itself. The ability to download/refresh binaries is a convenience feature I used to in vim-go. Instead of directing users to RTFM in case of missing binaries, it offers a quick way to fix problem with one command.

@abitrolly
abitrolly changed the base branch from next to dev March 11, 2021 18:57
@abitrolly
abitrolly force-pushed the download-binaries branch from e6de756 to b9a0220 Compare April 9, 2021 07:51
autoload/LanguageClient.vim:599:1: Use the abort attribute for functions in autoload (see Google VimScript Style Guide (Functions))
autoload/LanguageClient.vim:605:13: Prefer single quoted strings (see Google VimScript Style Guide (Strings))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants