Repository navigation
Fix bundled CLI current installer identity admission - #554
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Fix released CLI startup identity admission. The app bundles both GUI and CLI under
Contents/MacOS. macOS Foundation resolvesBundle.executableURLto the currently running CLI when launched through it, even though sealedCFBundleExecutablenames the GUI. The architecture gate previously rejected the CLI asinvalidBundleExecutablebefore any managed work. Read the sealed primary executable declaration and inspect the fixed GUI path instead.Evidence
currentBundleUnavailable, before helper or product mutation.invalidBundleExecutable; after the fix it passed this architecture boundary. That diagnostic copy is not a release or live acceptance claim../scripts/validate.shPASS; full native Swift tests PASS; changed production file executable-line coverage 73/75 = 97.333333% (>80.2%).Same LANE_1 assignment pcvantol/forge#141 and PR #75 lineage; frozen Forge 2.7.39/EP 2.3.106 producers, LANE_2 r30 read-only.