docs: the fs report prints, and a reader had no way to learn it stops there - #363
Merged
Merged
Conversation
… there The Filesystem observation section described what the report contains and never said where it does not go. "Is this in the trace?" is the first question a reader with a CI artifact asks, and the honest answer - no, and deliberately - was recorded on issue #302 and nowhere a user would look. Says it, with the reason, because "not implemented yet" and "designed and declined" are different facts and only one of them tells you to stop waiting. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the agent-testing documentation to explicitly state that the filesystem observation report is intentionally printed only and not persisted into the trace artifact, clarifying an important “designed and declined” product decision for auditors reading CI logs.
Changes:
- Adds a paragraph explaining that filesystem observation is emitted to stderr and not recorded in the trace.
- Documents the rationale for not adding an
fstrace lane (absolute-path permanence and long-lived reviewability concerns).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+941
to
+943
| survives the run. A lane was designed and declined, because a trace is a | ||
| COMMITTED artifact and these paths are absolute - `/home/alice/exports/ | ||
| acme-corp-2025.csv` would be baked into a file that is reviewed and diffed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One paragraph, closing the reader question #360 left open.
The Filesystem observation section says what the report contains and never says where it does not go. "Is this in the trace?" is the first thing anyone with a CI artifact asks, and the answer — no, and deliberately — was recorded on #302 and nowhere a user would ever look.
The distinction worth writing down is that "not implemented yet" and "designed and declined" are different facts, and only one of them tells you to stop waiting. The reason travels with it: a trace is a committed artifact, and these paths are absolute, so
/home/alice/exports/acme-corp-2025.csvwould be baked into a file that is reviewed and diffed forever — the same argument that keepsexecveout of the trap set for its argv.Closes out #302 entirely. Docs only; ratchets
diff size 9 <= 400.🤖 Generated with Claude Code