feat(grammar): selecting four options selected one, and said nothing - #329
Merged
Merged
Conversation
`Select` commits through the control's value setter, which is correct and is also a replacement. So the obvious spelling — four `Select` steps at one `<select multiple>` — left the last option standing, fired four `change` events at an app expecting one, and reported success. Nothing was available to write instead: a multi-selection is not a sequence of selections, it is one state the control ends up in. `Select "A", "B" and "C" from the "<label>" field` drives it to exactly that set in one commit, with one input+change. Set-a-state like `Check`, so the step means the same thing however the environment arrived. Every item is quoted, and that is the design. Option text is arbitrary app text: "Rock, Paper and Scissors" is one option on somebody's page, and a list split on commas and the word "and" would read it as three, silently. Names resolve before anything is selected, so a typo in the third option leaves the control untouched rather than half-applied, and the step reads the selection back to verify it took. Writing that check turned up why it was needed: a JS exception inside the driver does not reach Rust as an error, so the first version reported success on an option that does not exist. The outcome is now a value that comes back and is inspected. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
AminChirazi
force-pushed
the
relanded/2-count-capture
branch
from
August 1, 2026 10:00
545335d to
6b1ca15
Compare
AminChirazi
force-pushed
the
relanded/3-multi-select
branch
from
August 1, 2026 10:00
4fb301d to
99680a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selectcommits through the value setter, which is a replacement — so fourSelectsteps at one<select multiple>left the last option standing, fired fourchangeevents at an app expecting one, and reported success. Confirmed against a real page before writing anything.Select "A", "B" and "C" from the "<label>" fielddrives it to exactly that set in one commit, oneinput+change. Set-a-state likeCheck.Every item is quoted, and that is the design.
"Rock, Paper and Scissors"is one option on somebody's page; a split on commas and "and" would read it as three, silently.Names resolve before anything is selected, so a typo in the third leaves the control untouched, and the step reads the selection back to verify it took.
This is where the
call_js_fnbug surfaced: a JS exception does not reach Rust as anErr, so the first version reported success on an option that does not exist. The outcome is now a status value that comes back and is inspected.Red path: a missing option, and a single
<select>given a list. Proved live: four options in exactly onechangeevent, asserted on an event counter.The one question: still a recording — one target, one set of names, no branch or repetition.
🤖 Generated with Claude Code