Skip to content

Multi arch image architecture - #10

Merged
lhotovy merged 4 commits into
mainfrom
multi-arch-image-config
Oct 22, 2025
Merged

Multi arch image architecture #10
lhotovy merged 4 commits into
mainfrom
multi-arch-image-config

Conversation

@gtchax

@gtchax gtchax commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

Added multi arch image architecture build to github actions

Copilot AI review requested due to automatic review settings October 21, 2025 13:32

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a GitHub Actions workflow to build and push multi-architecture Docker images, supporting both amd64 and arm64 platforms. The workflow automates Docker image builds on pushes to main/master branches, tags, and pull requests, with automatic tagging based on branch names, semantic versioning, and latest tags for the default branch.

Key Changes:

  • Implements multi-architecture Docker image building for linux/amd64 and linux/arm64 platforms
  • Configures automated Docker Hub publishing with metadata-driven tagging strategy
  • Sets up Docker Buildx with QEMU for cross-platform builds and GitHub Actions caching

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +68 to +69
- name: Image digest
run: echo "Image pushed with digest ${{ steps.build.outputs.digest }}"

Copilot AI Oct 21, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The step references steps.build.outputs.digest, but the build step (line 57-66) has no id defined. The step should reference steps.meta.outputs.digest or add id: build to the 'Build and push Docker image' step.

Copilot uses AI. Check for mistakes.
@lhotovy
lhotovy self-requested a review October 22, 2025 08:36
Comment thread .github/workflows/docker-build.yml Outdated
- master
tags:
- "v*"
pull_request:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to only leave trigger on push (and potentially workflow_dispatch), on pull request is probably unneccessary.

@lhotovy
lhotovy merged commit a88ef80 into main Oct 22, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants