Fix release notarization and stamp Sparkle version at release time - #81
Merged
Merged
Conversation
austin-smith
marked this pull request as ready for review
July 16, 2026 06:09
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Notarization fix (v0.8.3 release failure):
Export Developer ID appstep (xcodebuild -exportArchive, methoddeveloper-id) between archive and DMG creation. Sparkle's nested helpers (Autoupdate,Updater.app, both XPC services) ship ad-hoc signed; export re-signs all nested code with the Developer ID identity and secure timestamps. Copying the app straight out of the xcarchive left the ad-hoc signatures in place, and Apple's notary service rejected the submission (status: Invalid).Autoupdateis no longer ad-hoc signed and that the app'sCFBundleVersionmatches the release tag.notarytool submit --waitcan exit 0 on anInvalidverdict, which previously surfaced as a confusing stapler error. Any non-Acceptedstatus dumps Apple's per-filenotarytool loginto the job output and fails immediately.Versioning:
MARKETING_VERSION(0.8.3) and one plainCURRENT_PROJECT_VERSION(1, reset per version bump), shared by every target. No derived settings in the project file; Xcode's Version/Build panes look and behave as standard.CFBundleVersion, so the release workflow stamps the marketing version into it at archive time via aCURRENT_PROJECT_VERSION="${TAG#v}"build-setting override — released DMGs carryCFBundleVersion == marketing version, and every Sparkle release bumps the marketing version. The workflow's verify step fails the release if the stamp is missing.ProjectVersionConsistencyTests: fails the suite (and therefore PR CI) ifMARKETING_VERSIONorCURRENT_PROJECT_VERSIONvalues diverge anywhere inproject.pbxproj— Xcode's per-target Version/Build panes can silently fork the values apart when edited by hand.Why
The v0.8.3 release failed notarization (first release with an embedded framework). Separately, version numbers needed to be maintainable in one place: with two app targets, Xcode's General pane edits can fork
MARKETING_VERSIONper target and drift out of sync unnoticed.Validation
CFBundleVersion 0.8.3/ marketing0.8.3; a plain local build stamps1/0.8.3; Xcode shows single unsplit Version/Build fields.0.8.3vs6.6.6) with both values named in the message, and pass on the clean file.codesign -dvvshowsSignature=adhoc), which Apple rejects.After merge: delete and re-push the
v0.8.3tag (nothing was published under it — the release job died before creating the GitHub release, and no appcast was deployed).