Add motion policy tests and fix settings pane height - #77
Merged
Merged
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
MotionPolicyTestspinning the animation speed contract: the catalog's stored scales,from(rawValue:)falling back to Normal on an unknown id, the Reduce Motion clamp overriding every speed,duration(_:)math,isInstant, and the animation builders returning nil (apply without animating) whenever motion is off.Why
MotionPolicy shipped in #76 without unit tests; everything else its size in the repo is covered, and the raw-value fallback in particular protects old saved defaults against a future option rename. The pane height in #76 was set without visual verification; 355 is measured from a screenshot of the rendered window (content spans 335pt below the toolbar divider plus the form's bottom inset).
Validation