Restore card flight animations - #75
Merged
Merged
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
dropAnimationOffset,dragReturnOffset,overlayTilt,isDroppingCards,droppingSelection,isReturningDrag,returningCards,pendingDropDestination, and the waste return anchor) fromDragInteractionControllerback to@StateonContentView— the storage it had before Stop per-frame whole-board re-evaluation #71.DragInteractionControllernow holds only the true per-frame gesture state:dragTranslationandactiveTarget.DragOverlayViewreceives the flight-boundary fields as plain values from ContentView and keeps reading onlydragTranslationfrom the controller.Why
#71 broke every card flight animation: tap-to-move, drag-drop snap, auto-finish, and the invalid-drop return spring all became instant teleports. These flights are driven by
withAnimationwrites, and an@Observableproperty loses that transaction when another property has already invalidated the reader in the same tick — the first unanimated write (isDroppingCards = true) stamps the update, and the spring on the offset write behind it is dropped.@Stateanimates per attribute, so the identical write sequence keeps its spring.None of the shipped performance work is given back: the per-frame drag writes stay isolated in the controller, the moved fields change twice per flight (not per frame) at moments where ContentView already re-evaluates for toolbar enablement, and the board views still prune via their
Equatablegates.Validation
simctlvideo → per-frame hash diff): pre-Reduce per-move gameplay lag #70 and Reduce per-move gameplay lag #70 show an ~8-frame flight run, Stop per-frame whole-board re-evaluation #71 and current main show a single-frame teleport.