Base recycle penalty on dealt draw mode - #29
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
austin-smith
changed the title
austin-smith
marked this pull request as ready for review
July 5, 2026 05:14
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The draw-one recycle penalty checked the live
stockDrawCount, while the time bonus and statistics usescoringDrawCount(frozen at deal/redeal). Switching draw modes mid-game let the two disagree — e.g. toggling to 3-card draw right before each recycle dodged the −100 penalty while still playing (and being scored as) a 1-card draw game.The penalty now keys off
scoringDrawCountso all scoring rules agree on the dealt mode.recycleWaste()checksscoringDrawCountinstead ofstockDrawCountscoringDrawCountexposed asprivate(set)(matchesstockDrawCount)