Skip to content

Add alternate app icons for iOS - #28

Merged
austin-smith merged 1 commit into
mainfrom
app-icon-selector
Jul 4, 2026
Merged

austin-smith merged 1 commit into
mainfrom
app-icon-selector

Conversation

@austin-smith

Copy link
Copy Markdown
Owner

Adds an iOS app icon picker, with two initial icon options: Default and Queen of Hearts.

@cursor

cursor Bot commented Jul 4, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

https://github.com/austin-smith/ComputerSolitaire/blob/2e7178b3e68ed00e9454602ab7a262a728d11b5f/Views/AppIconPickerView.swift#L3
P1 Badge Remove UIKit dependency from icon picker

For the iOS settings icon feature, this imports UIKit and the new code uses UIApplication APIs; the repo-level AGENTS.md explicitly marks the app as 100% SwiftUI and says not to add UIKit/AppKit usage or imports. This same dependency is also added in SettingsView, so the change violates the project’s non-negotiable platform contract unless maintainers explicitly approve an exception.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@austin-smith
austin-smith merged commit 2873d4a into main Jul 4, 2026
2 checks passed
@austin-smith
austin-smith deleted the app-icon-selector branch July 4, 2026 21:53
@austin-smith austin-smith linked an issue Jul 5, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add alternate app icons

1 participant