Hint system improvements and macOS CI test workflow - #12
Merged
Merged
Conversation
Consolidate and enhance move evaluation logic in AutoMoveAdvisor: add candidateSelections, allEvaluations, bestAdvisableMoveEvaluation/bestAdvisableDestination, isAdvisableMove and helper heuristics (immediate gains, foundation unlock checks). Change mobility scoring to use candidateSelections. Simplify HintAdvisor to rely on AutoMoveAdvisor (remove duplicated selection and filtering code). Update GameSession to attempt advisable auto-moves from tapped foundations and make queueBestAutoMove accept an optional playFailureFeedback flag. Also add a macOS build workflow snippet to AGENTS.md.
Add a new ComputerSolitaireTests target and test suite, update project files, and refactor advisor logic. Updates include: adding ComputerSolitaireTests.xctest target to the Xcode project, adding HintAdvisabilityTests.swift with multiple unit and performance tests, and adding a Test Workflow snippet to AGENTS.md. AutoMoveAdvisor.swift was refactored: foundationMoveUnlocksForwardFollowUp was renamed and replaced by isFoundationRollbackAdvisable and decomposed into smaller helpers (OpportunityBaseline, FoundationRollbackPolicy, ImmediateOpportunity and ranking logic), plus new evaluation and selection logic for assessing rollback/advisability. Also update .gitignore (build/ -> .build/).
Add .github/workflows/ci.yml to run macOS unit tests on pull requests and merge groups. Introduces a macOS job (runs-on: macos-26) that checks out the repo, runs xcodebuild test for ComputerSolitaire (Debug configuration, platform=macOS) with code signing disabled, and uploads the test result bundle on failure. Also configures minimal permissions and concurrency to cancel in-progress runs for the same workflow/ref.
Update the GitHub Actions workflow name in .github/workflows/ci.yml from 'CI' to 'Build & Test' to make the purpose more explicit in the Actions UI.
Rename macOS job to "macOS Build & Test" and add a new iOS Build job to the GitHub Actions workflow that runs xcodebuild for the iOS Simulator (code signing disabled). Update the Xcode project file: insert a PBXContainerItemProxy section, move/re-add the test XCBuildConfiguration blocks, and bump MARKETING_VERSION from 0.4.1 to 0.5.0 for the relevant targets. These changes enable basic iOS CI builds and update the project metadata.
Owner
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8d599b6809
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gameplay and Hint Logic
AutoMoveAdvisorand reused it inHintAdvisor.Tests
ComputerSolitaireTestsunit test target.HintAdvisabilityTestsfor:CI and Workflow
.github/workflows/ci.yml:pull_requesttomainandmerge_groupxcodebuild testonmacos-26.xcresultbundle on failureAGENTS.md,.gitignore).