Skip to content

Show new server drafts in the macOS sidebar - #147

Merged
austin-smith merged 5 commits into
mainfrom
show-new-server-drafts
Sep 19, 2026
Merged

austin-smith merged 5 commits into
mainfrom
show-new-server-drafts

Conversation

@austin-smith

Copy link
Copy Markdown
Owner

What Changed

  • Represent new macOS servers as selectable draft rows with names that update as the form is edited.
  • Restore the previous server selection on cancellation, with safe fallback when that server is gone, and allow cancelling the first server draft.
  • Add four navigation regression tests and document signed-build requirements for manual testing.

Why

The new-server form previously appeared without a matching sidebar selection, making it unclear which server was being edited. Drafts now appear immediately while persistence still happens only after a successful save.

UI Changes

  • Show a selected New Server row with an Unsaved subtitle, updating its name as the user types.
  • Disable the add button while a draft is open; remove the draft on cancellation and select the saved server after creation.
  • Preserve discard confirmation when navigating away from an edited draft, and hide the empty-list message while a draft is visible.

Validation

  • macOS test suite: 229 tests passed, including four new navigation regression tests.
  • iOS unsigned compile check passed; SwiftLint and git diff --check passed.
  • Structured code review found no actionable blockers.
  • Manually verified draft selection, live name changes, validation failure, cancellation, and starting a fresh draft.
  • Built macOS with normal Apple Development signing in isolated DerivedData; strict deep signature verification passed, and the app launched with the saved server connected.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-19T05:11:57.868724Z e8225a1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@austin-smith
austin-smith merged commit 38ec7f4 into main Sep 19, 2026
3 checks passed
@austin-smith
austin-smith deleted the show-new-server-drafts branch September 19, 2026 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant