Skip to content

Simplify toolbar icons and highlight active filters - #146

Merged
austin-smith merged 5 commits into
mainfrom
remove-circled-toolbar-icons
Sep 19, 2026
Merged

austin-smith merged 5 commits into
mainfrom
remove-circled-toolbar-icons

Conversation

@austin-smith

@austin-smith austin-smith commented Sep 19, 2026

Copy link
Copy Markdown
Owner

What Changed

  • Replace circled action, filter, and sort toolbar symbols with plain variants on iOS and macOS.
  • Use native prominent button styling when label filters are active, with stable popover anchors and accessible active/inactive values.

Why

Avoid redundant circles inside system toolbar buttons and distinguish active filters through a filled background instead of icon color alone.

UI Changes

  • Active filter buttons have an accent-filled system background; clearing filters restores the neutral appearance.
  • Filter buttons still open their existing popovers, which remain open when filter state changes.

Validation

  • iOS simulator and macOS builds passed.
  • Manually verified active and cleared filter states and popover behavior on both platforms.
  • SwiftLint and git diff --check passed.
  • Autoreview found no actionable issues.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 19, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-19T06:07:34.094139Z 36e7ac9 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0e734a3e62

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread BitDream/Views/iOS/iOSContentView.swift Outdated
@austin-smith austin-smith changed the title Remove circled toolbar icons Simplify toolbar icons and highlight active filters Sep 19, 2026
@austin-smith

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 36e7ac964b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread BitDream/Views/iOS/iOSContentView.swift
@austin-smith
austin-smith merged commit ac61892 into main Sep 19, 2026
3 checks passed
@austin-smith
austin-smith deleted the remove-circled-toolbar-icons branch September 19, 2026 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant